Core: Work around more IE activeElement bugs #1523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Support: IE 9 - 11 only | ||
| // IE may return null instead of an element | ||
| // Interestingly, this only seems to occur when NOT in an iframe | ||
| if ( !activeElement ) { |
There was a problem hiding this comment.
Can this just be combined in the conditional below?
There was a problem hiding this comment.
I prefer the clarity of what workarounds exist over the minuscule byte savings of combining.
|
I was a bit concerned about uses of Line 151 in f330278 https://github.com/scottgonzalez/jquery-ui/blob/ie-activeelement/ui/core.js#L84-90 And I still hate focus/blur. |
|
Looks "good" to me (as good as these can get). I prefer the separate if statement as well, since that keeps the support comments separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazingly 76c2755 caused regressions because IE 9 - 11 can return
nullfordocument.activeElementwhen not in an iframe. The fun never stops when dealing with focus in IE...